| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com> |
| Subject: | Re: Add important info about ANALYZE after create Functional Index |
| Date: | 2020-11-01 12:29:02 |
| Message-ID: | 20201101122902.GE3000@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Nov 01, 2020 at 09:23:44AM +0900, Michael Paquier wrote:
> By doing so, there is no need to include pg_statistic.h in index.c.
> Except that, the logic looks fine at quick glance. In the long-term,
> I also think that it would make sense to move both routnes out of
> heap.c into a separate pg_statistic.c. That's material for a separate
> patch of course.
I have looked again at that, and applied it after some tweaks.
Particularly, I did not really like the use of "old" and "new" for the
copy from the old to a new relation in the new function, so I have
replaced that by "from" and "to".
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Cramer | 2020-11-01 12:58:06 | how to replicate test results in cf-bot on travis |
| Previous Message | Michael Paquier | 2020-11-01 10:23:51 | Re: Consistent error reporting for encryption/decryption in pgcrypto |