Re: Consistent error reporting for encryption/decryption in pgcrypto

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Georgios Kokolatos <gkokolatos(at)protonmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Consistent error reporting for encryption/decryption in pgcrypto
Date: 2020-10-31 01:03:49
Message-ID: 20201031010349.GA1497@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 30, 2020 at 11:23:27PM +0100, Daniel Gustafsson wrote:
> > On 30 Oct 2020, at 16:54, Georgios Kokolatos <gkokolatos(at)protonmail(dot)com> wrote:
>
> > I did notice that the cfbot [1] is not failing for this patch.
>
> I assume you mean s/failing/passing/? I noticed the red Travis and Appveyor
> runs, will fix over the weekend. Thanks for the heads-up.

It seems to me that you are just missing to declare a new error number
in px.h, so I would suggest to just use -19.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-10-31 01:04:35 Re: Should the function get_variable_numdistinct consider the case when stanullfrac is 1.0?
Previous Message Tom Lane 2020-10-31 00:50:49 Re: Should the function get_variable_numdistinct consider the case when stanullfrac is 1.0?