Re: Non-configure build of thread_test has been broken for awhile

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Non-configure build of thread_test has been broken for awhile
Date: 2020-10-26 23:30:15
Message-ID: 20201026233015.GC4951@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 20, 2020 at 12:25:48PM -0400, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > On 2020-Oct-18, Tom Lane wrote:
> >> It doesn't really seem sane to me to support two different build
> >> environments for thread_test, especially when one of them is so
> >> little-used that it can be broken for years before we notice.
> >> So I'd be inclined to rip out the Makefile and just consider
> >> that thread_test.c is *only* meant to be used by configure.
> >> If we wish to resurrect the standalone build method, we could
> >> probably do so by adding LIBS to the Makefile's link command
> >> ... but what's the point, and what will keep it from getting
> >> broken again later?
>
> > Standalone usage of that program is evidently non-existant, so +1 for
> > removing the Makefile and just keep the configure compile path for it.
>
> I concluded that if thread_test.c will only be used by configure,
> then we should stick it under $(SRCDIR)/config/ and nuke the
> src/test/thread/ subdirectory altogether. See attached.

Sounds good.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-10-27 00:21:35 Re: Commitfest 2020-11
Previous Message Bruce Momjian 2020-10-26 23:18:52 Re: Wrong example in the bloom documentation