Re: Non-configure build of thread_test has been broken for awhile

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Non-configure build of thread_test has been broken for awhile
Date: 2020-10-19 21:41:43
Message-ID: 20201019214143.GA10439@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-Oct-18, Tom Lane wrote:

> It doesn't really seem sane to me to support two different build
> environments for thread_test, especially when one of them is so
> little-used that it can be broken for years before we notice.
> So I'd be inclined to rip out the Makefile and just consider
> that thread_test.c is *only* meant to be used by configure.
> If we wish to resurrect the standalone build method, we could
> probably do so by adding LIBS to the Makefile's link command
> ... but what's the point, and what will keep it from getting
> broken again later?

Standalone usage of that program is evidently non-existant, so +1 for
removing the Makefile and just keep the configure compile path for it.

BTW the only animal reporting without thread-safety in the buildfarm is
gaur.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2020-10-19 23:20:34 Re: [PATCH] Add extra statistics to explain for Nested Loop
Previous Message Tom Lane 2020-10-19 18:37:02 Re: Probable documentation errors or improvements