pg_restore error message during ENOSPC with largeobj

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: pg_restore error message during ENOSPC with largeobj
Date: 2020-10-18 01:02:32
Message-ID: 20201018010232.GF9241@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I overflowed my homedir while testing with pg_reload, and got:
|pg_restore: error: could not write to large object (result: 18446744073709551615, expected: 30)

src/bin/pg_dump/pg_backup_archiver.c

f (res != AH->lo_buf_used)
fatal("could not write to large object (result: %lu, expected: %lu)",
(unsigned long) res, (unsigned long) AH->lo_buf_used);

; 18446744073709551615 - 1<<64
-1

I guess casting to long was the best option c. 2002 (commit 6faf8024f) but I
gather the modern way is with %z.

I confirmed this fixes the message.
|pg_restore: error: could not write to large object (result: -1, expected: 16384)

--
Justin

Attachment Content-Type Size
v1-0001-print-size_t-with-zd-rather-than-casting-to-lu.patch text/x-diff 2.9 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hou, Zhijie 2020-10-18 02:17:07 RE: Parallel copy
Previous Message Justin Pryzby 2020-10-17 19:21:34 Re: jit and explain nontext