|From:||Bruce Momjian <bruce(at)momjian(dot)us>|
|To:||Justin Pryzby <pryzby(at)telsasoft(dot)com>|
|Subject:||Re: pg_upgrade: fail early if a tablespace dir already exists for new cluster version|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On Fri, Oct 9, 2020 at 02:23:10PM -0500, Justin Pryzby wrote:
> In my local branch, I had revised this comment to say:
> + * Note, v8.4 has no tablespace_suffix, which is fine so long as the version we
> + * being upgraded *to* has a suffix, since it's not allowed to pg_upgrade from
> + * a version to the same version if tablespaces are in use.
OK, updated patch attached. Also, from your original patch, I didn't
need to call canonicalize_path() since we are not comparing paths, and I
didn't need to include common/relpath.h. I also renamed a variable.
The usefulness of a cup is in its emptiness, Bruce Lee
|Next Message||Ranier Vilela||2020-10-10 01:37:01||Re: Possible NULL dereferencing null pointer (src/backend/executor/nodeIncrementalSort.c)|
|Previous Message||Tom Lane||2020-10-09 22:45:23||Re: Possible NULL dereferencing null pointer (src/backend/executor/nodeIncrementalSort.c)|