Re: Probably typo in multixact.c

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Probably typo in multixact.c
Date: 2020-10-08 01:26:39
Message-ID: 20201008012639.GA3457@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 08, 2020 at 01:15:35AM +0000, Hou, Zhijie wrote:
> Hi
>
> In multixact.c I found some comments like the following:
>
> * Similar to AtEOX_MultiXact but for COMMIT PREPARED
> * Discard the local MultiXactId cache like in AtEOX_MultiXact
>
> Since there's no function called "AtEOX_MultiXact" in the code,
> I think the "AtEOX_MultiXact" may be a typo.
>
> AtEOXact_MultiXact seems to be the right function here.

Yes, that looks like a simple typo to me as well.
AtEOXact_MultiXact() shares portions of the logics in
PostPrepare_MultiXact and multixact_twophase_postcommit.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andy Fan 2020-10-08 01:34:51 Re: [PATCH] Keeps tracking the uniqueness with UniqueKey
Previous Message Hou, Zhijie 2020-10-08 01:15:35 Probably typo in multixact.c