Re: BUG #16419: wrong parsing BC year in to_date() function

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #16419: wrong parsing BC year in to_date() function
Date: 2020-09-30 23:41:47
Message-ID: 20200930234147.GI26841@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Wed, Sep 30, 2020 at 07:26:55PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > On Wed, Sep 30, 2020 at 06:10:38PM -0400, Robert Haas wrote:
> >> On Wed, Sep 30, 2020 at 5:35 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >>> By that logic, we should never fix any bug in a back branch.
>
> >> No, by that logic, we should not change any behavior in a back-branch
> >> upon which a customer is plausibly relying. No one relies on a certain
> >> query causing a server crash, for example, or a cache lookup failure,
> >> so fixing those things can only help people. But there is no reason at
> >> all why someone shouldn't be relying on this very old and
> >> long-established behavior not to change in a minor release.
>
> > That is an interesting distinction.
>
> I don't want to sound like I'm totally without sympathy for Robert's
> argument. But I do say it's a judgment call, and my judgment remains
> that this patch is appropriate to back-patch.

Agreed. I was just thinking it was an interesting classification that
no one relies on crashes, or query failures.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Robert Haas 2020-10-01 00:24:30 Re: BUG #16419: wrong parsing BC year in to_date() function
Previous Message Tom Lane 2020-09-30 23:26:55 Re: BUG #16419: wrong parsing BC year in to_date() function

Browse pgsql-hackers by date

  From Date Subject
Next Message Soumyadeep Chakraborty 2020-09-30 23:52:02 Re: avoid bitmapOR-ing indexes with scan condition inconsistent with partition constraint
Previous Message Tom Lane 2020-09-30 23:26:55 Re: BUG #16419: wrong parsing BC year in to_date() function