Re: BUG #16419: wrong parsing BC year in to_date() function

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #16419: wrong parsing BC year in to_date() function
Date: 2020-09-30 17:56:42
Message-ID: 20200930175642.GC26841@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Tue, Sep 29, 2020 at 01:26:29PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > On Fri, Sep 4, 2020 at 12:45:36PM -0700, David G. Johnston wrote:
> >>> Because we already have the to_date/make_date inconsistency, and the -1
> >>> to -2 BC mapping is confusing, and doesn't match Oracle, I think the
> >>> clean solution is to change PG 14 to treat -1 as 1 BC, and document the
> >>> incompatibility in the release notes.
>
> >> I agree that someone else should write another patch to fix the behavior for
> >> v14.  Still suggest committing the proposed patch to master and all supported
> >> versions to document the existing behavior correctly.  The fix patch can work
> >> from that.
>
> > I think we need to apply the patches to all branches at the same time.
> > I am not sure we want to document a behavior we know will change in PG
> > 14.
>
> I think this is nuts. The current behavior is obviously broken;
> we should just treat it as a bug and fix it, including back-patching.
> I do not think there is a compatibility problem of any significance.
> Who out there is going to have an application that is relying on the
> ability to insert BC dates in this way?

You are agreeing with what I am suggesting then?

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2020-09-30 18:11:54 Re: BUG #16419: wrong parsing BC year in to_date() function
Previous Message Andrew Dunstan 2020-09-30 17:02:39 Re: BUG #16644: null value for defaults in OLD variable for trigger

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2020-09-30 18:02:14 Re: [PATCH] audo-detect and use -moutline-atomics compilation flag for aarch64
Previous Message Zidenberg, Tsahi 2020-09-30 16:04:49 Re: [PATCH] audo-detect and use -moutline-atomics compilation flag for aarch64