Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit
Date: 2020-09-29 05:50:38
Message-ID: 20200929055038.GD7117@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Aug 03, 2020 at 04:41:58PM +0530, Bharath Rupireddy wrote:
> IMHO, we are not fully solving the problem with
> idle_in_session_timeout on remote backends though we are addressing
> the main problem partly by letting the remote sessions close by
> themselves.

This patch fails to compile on Windows. And while skimming through
the patch, I can see that you are including libpq-int.h in a place
different than src/interfaces/libpq/. This is incorrect as it should
remain strictly as a header internal to libpq.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-09-29 05:56:41 Re: new heapcheck contrib module
Previous Message Michael Paquier 2020-09-29 05:44:27 Re: WIP: System Versioned Temporal Table