Re: Prefer TG_TABLE_NAME over TG_RELNAME in tests

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Prefer TG_TABLE_NAME over TG_RELNAME in tests
Date: 2020-09-24 03:17:46
Message-ID: 20200924031746.GG7405@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 23, 2020 at 12:07:14PM +0200, Daniel Gustafsson wrote:
> TG_RELNAME was marked deprecated in commit 3a9ae3d2068 some 14 years ago, but
> we still use it in the triggers test suite (test added in 59b4cef1eb74a a year
> before deprecation). Seems about time to move over to TG_TABLE_NAME ourselves,
> as TG_RELNAME is still covered by the test added in the deprecation commit.

No objections from here to remove that from the core tests. It is
worth noting that Debian Code Search hints that this is used in some
extensions:
https://codesearch.debian.net/search?q=TG_RELNAME&literal=1

These are pgformatter, bucardo, sql-ledger, ledgersmb and davical.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Nancarrow 2020-09-24 03:25:22 Re: Parallel INSERT (INTO ... SELECT ...)
Previous Message Greg Nancarrow 2020-09-24 02:56:09 Re: Parallel copy