Re: Command statistics system (cmdstats)

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Smith, Peter" <peters(at)fast(dot)au(dot)fujitsu(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, vinayak <Pokale_Vinayak_q3(at)lab(dot)ntt(dot)co(dot)jp>
Subject: Re: Command statistics system (cmdstats)
Date: 2020-09-23 02:12:14
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Wed, Sep 23, 2020 at 10:41:10AM +0900, Michael Paquier wrote:
> I think that this remark is a bit unfair. When it comes to any patch
> in the commit fest, and I have managed a couple of them over the
> years, I have tried to keep a neutral view for all of them, meaning
> that I only let the numbers speak by themselves, mostly:
> - When has a patch lastly been updated.
> - What's the current state in the CF app If the patch had no reviews
> and still in "Needs review", simply switch it to "waiting on author".

Sorry, forgot to mention here that this is in the case where a patch
does not apply anymore or that the CF bot complains, requiring a check
of the patch from the author.

> If the patch has been waiting on author for more than two weeks, it
> would get marked as RwF at the end of the CF. There are also cases
> where the status of the patch is incorrect, mostly that a patch
> waiting on author because of a review was not updated as such in the
> CF app. In this case, and in the middle of a CF, this would get get
> marked as Rwf, but the author would get a reminder of that.

Last sentence here is incorrect as well: s/get get/not get/, and the
author would be reminded to update his/her patch.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message 2020-09-23 02:26:13 RE: [Patch] Optimize dropping of relation buffers using dlist
Previous Message Andres Freund 2020-09-23 02:05:36 Re: Syncing pg_multixact directories