| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Smith, Peter" <peters(at)fast(dot)au(dot)fujitsu(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, vinayak <Pokale_Vinayak_q3(at)lab(dot)ntt(dot)co(dot)jp>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | Re: Command statistics system (cmdstats) |
| Date: | 2020-09-17 04:51:23 |
| Message-ID: | 20200917045123.GG2873@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 10, 2020 at 01:45:02PM -0400, Robert Haas wrote:
> My spidey sense is tingling here, telling me that we need some actual
> benchmarking. Like, suppose we test the two patches under normal cases
> and under cases that are constructed to be as bad as possible for each
> of them. Or suppose we test this patch with the lock mitigation
> strategies and then remove the mitigations for some inexpensive
> command (e.g. SHOW) and then use pgbench to spam that command. Like
> you, I suspect that the locking mitigations are important in some
> workloads, but it would be good to have some figures to back that out,
> as well as to find out whether there's still too much overhead.
This patch has not received any replies after this comment for three
months, so I am marking it as returned with feedback. I agree that
this should be benchmarked carefully.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-09-17 04:58:28 | Re: Refactor pg_rewind code and make it work against a standby |
| Previous Message | Michael Paquier | 2020-09-17 04:46:53 | Re: Is it useful to record whether plans are generic or custom? |