Re: Simplified version of read_binary_file (src/backend/utils/adt/genfile.c)

From: Andres Freund <andres(at)anarazel(dot)de>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Simplified version of read_binary_file (src/backend/utils/adt/genfile.c)
Date: 2020-09-11 18:09:30
Message-ID: 20200911180930.ok4ibw5zhwuyj35w@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-09-11 14:10:31 -0300, Ranier Vilela wrote:
> Em sex., 11 de set. de 2020 às 14:01, Alvaro Herrera <
> alvherre(at)2ndquadrant(dot)com> escreveu:
> > On 2020-Sep-11, Ranier Vilela wrote:
> > This code was very recently rewritten in 96d1f423f95d, and I doubt that
> > taking out half the algorithm without studying how it got that way is a
> > great idea.
> >
> Works with all regress tests (199, same as the HEAD with msvc 2019 64 bits
> except partition_prune)
> Works with pgbench (pgbench -U postgres -c 50 -j 2 -t 10000 example)
> And works with local installation, without adverse effects, for now.

Have your read the commit message for 96d1f423f95d ?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2020-09-11 18:13:58 Re: Weird corner-case failure mode for VPATH builds
Previous Message Tomas Vondra 2020-09-11 18:05:10 Re: WIP: BRIN multi-range indexes