Re: Weird corner-case failure mode for VPATH builds

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Weird corner-case failure mode for VPATH builds
Date: 2020-09-11 16:58:41
Message-ID: 20200911165841.GA7469@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-Sep-11, Robert Haas wrote:

> On Fri, Sep 4, 2020 at 9:49 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > I discovered a problem today while trying to do a VPATH build on
> > a machine I don't use that often:
> >
> > $ make
> > ...
> > In file included from /home/tgl/pgsql/src/include/postgres.h:47,
> > from /home/tgl/pgsql/src/common/hashfn.c:24:
> > /home/tgl/pgsql/src/include/utils/elog.h:71:10: fatal error: utils/errcodes.h: No such file or directory
> > 71 | #include "utils/errcodes.h"
> > | ^~~~~~~~~~~~~~~~~~
> > compilation terminated.
>
> I think I've seen this before, but I don't have an opinion on how to fix it.

Me too. It would be useful to have a way to report that build artifacts
are in the source dir that should be in the build dir. I don't know if
this is in any way workable.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2020-09-11 17:01:04 Re: Simplified version of read_binary_file (src/backend/utils/adt/genfile.c)
Previous Message Robert Haas 2020-09-11 16:53:58 Re: Weird corner-case failure mode for VPATH builds