Re: shared-memory based stats collector

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: alvherre(at)2ndquadrant(dot)com, andres(at)anarazel(dot)de, michael(at)paquier(dot)xyz, thomas(dot)munro(at)gmail(dot)com, tomas(dot)vondra(at)2ndquadrant(dot)com, ah(at)cybertec(dot)at, magnus(at)hagander(dot)net, robertmhaas(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org
Subject: Re: shared-memory based stats collector
Date: 2020-09-09 14:41:20
Message-ID: 20200909144119.GR29590@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greetings,

* Kyotaro Horiguchi (horikyota(dot)ntt(at)gmail(dot)com) wrote:
> > Shouldn't this:
> >
> > a) be back-patched, as the other change was
> > b) also include a change to have the stats collector (which I realize is
> > removed later on in this patch set, but we're talking about fixing
> > existing things..) for the same reason, and because there isn't much
> > point in trying to write out the stats after we get a SIGQUIT, since
> > we're just going to blow them away again since we're going to go
> > through crash recovery..?
> >
> > Might be good to have a separate thread to address these changes.
>
> +1

Just FYI, Tom's started a thread which includes this over here-

https://postgr.es/m/1850884.1599601164@sss.pgh.pa.us

Thanks,

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-09-09 14:46:28 Re: SIGQUIT handling, redux
Previous Message Stephen Frost 2020-09-09 14:39:00 Re: SIGQUIT handling, redux