| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | noah(at)leadboat(dot)com |
| Cc: | tgl(at)sss(dot)pgh(dot)pa(dot)us, pryzby(at)telsasoft(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: v13: CLUSTER segv with wal_level=minimal and parallel index creation |
| Date: | 2020-09-09 05:40:37 |
| Message-ID: | 20200909.144037.128324049040850843.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thank you for the checking.
At Tue, 8 Sep 2020 21:05:43 -0700, Noah Misch <noah(at)leadboat(dot)com> wrote in
> On Mon, Sep 07, 2020 at 07:47:09PM -0700, Noah Misch wrote:
> After looking closer, I've moved the test to reindex_catalog.sql; see that
> file's header comment for the reasons. One now needs this command:
>
> printf '%s\n%s\n%s\n' 'log_statement = all' 'wal_level = minimal' 'max_wal_senders = 0' >/tmp/minimal.conf
> make check-tests TESTS=reindex_catalog TEMP_CONFIG=/tmp/minimal.conf
I missed the file. It is surely the best place.
> RelationBuildDesc() calls RelationInitPhysicalAddr(), so RelationBuildDesc()
> can stop calling RelFileNodeSkippingWAL(). The attached version makes it so,
> and I plan to push it.
Sure. relNode is filled with zeros so RelationInitPhysicalAddr() works
correctly for RelationBuildDesc().
Both changes look good to me.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yugo NAGATA | 2020-09-09 05:49:24 | Re: Implementing Incremental View Maintenance |
| Previous Message | Fujii Masao | 2020-09-09 05:40:12 | Re: Inconsistent Japanese name order in v13 contributors list |