| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Hao Wu <hawu(at)vmware(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: default partition and concurrent attach partition |
| Date: | 2020-09-08 22:13:30 |
| Message-ID: | 20200908221330.GA3064@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-Sep-08, Alvaro Herrera wrote:
> Andres added to CC because of TTS interface: apparently calling
> slot_getallattrs() on a virtual slot raises error that "getsomeattrs is
> not required to be called on a virtual tuple table slot". I'm thinking
> that this exposes implementation details that should not be necessary
> for a caller to know; patch 0001 fixes that at the problematic caller by
> making the slot_getallatrs() call conditional on the slot not being
> virtual, but I wonder if the better fix isn't to remove the elog(ERROR)
> at tts_virtual_getsomeattrs.
Actually I misread the code, so this is all bogus. Nevermind ...
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-09-08 22:13:58 | Re: More aggressive vacuuming of temporary tables |
| Previous Message | Andres Freund | 2020-09-08 21:47:53 | Re: More aggressive vacuuming of temporary tables |