| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | 李杰(慎追) <adger(dot)lj(at)alibaba-inc(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, 曾文旌(义从) <wenjing(dot)zwj(at)alibaba-inc(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | Re: 回复：how to create index concurrently on partitioned table |
| Date: | 2020-09-08 02:39:16 |
| Message-ID: | 20200908023915.GD7158@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for completing and pushing the REINDEX patch and others.
Here's a rebasified + fixed version of the others.
On Tue, Sep 01, 2020 at 02:51:58PM +0900, Michael Paquier wrote:
> The REINDEX patch is progressing its way, so I have looked a bit at
> the part for CIC.
>
> Visibly, the case of multiple partition layers is not handled
> correctly. Here is a sequence that gets broken:
..
> This fails as follows:
> ERROR: XX000: unrecognized node type: 2139062143
> LOCATION: copyObjectImpl, copyfuncs.c:5718
Because copyObject needed to be called within a longlived context.
Also, my previous revision failed to implement your suggestion to first build
catalog entries with INVALID indexes and to then reindex them. Fixed.
--
Justin
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Allow-CREATE-INDEX-CONCURRENTLY-on-partitioned-ta.patch | text/x-diff | 13.0 KB |
| v6-0002-Implement-CLUSTER-of-partitioned-table.patch | text/x-diff | 10.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2020-09-08 02:47:09 | Re: v13: CLUSTER segv with wal_level=minimal and parallel index creation |
| Previous Message | Masahiko Sawada | 2020-09-08 02:36:45 | Re: Online checksums verification in the backend |