| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, alvherre(at)2ndquadrant(dot)com, andres(at)anarazel(dot)de, thomas(dot)munro(at)gmail(dot)com, tomas(dot)vondra(at)2ndquadrant(dot)com, ah(at)cybertec(dot)at, magnus(at)hagander(dot)net, robertmhaas(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: shared-memory based stats collector |
| Date: | 2020-09-07 02:04:19 |
| Message-ID: | 20200907020419.GC2455@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 03, 2020 at 01:16:59PM -0400, Stephen Frost wrote:
> Shouldn't this:
>
> a) be back-patched, as the other change was
0001 is just a piece of refactoring, so I see no strong argument in
favor of a backpatch, IMHO.
> b) also include a change to have the stats collector (which I realize is
> removed later on in this patch set, but we're talking about fixing
> existing things..) for the same reason, and because there isn't much
> point in trying to write out the stats after we get a SIGQUIT, since
> we're just going to blow them away again since we're going to go
> through crash recovery..?
>
> Might be good to have a separate thread to address these changes.
>
> I've looked through (some of) this thread and through the patches also
> and hope to provide a review of the bits that should be targetting v14
> (unlike the above) soon.
The latest patch set fails to apply and the CF bot is complaining, so
a rebase is needed. I have switched the patch as waiting on author.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-09-07 02:06:12 | Re: Spurious "apparent wraparound" via SimpleLruTruncate() rounding |
| Previous Message | Michael Paquier | 2020-09-07 01:58:43 | Re: 回复：how to create index concurrently on partitioned table |