| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Switch to multi-inserts for pg_depend |
| Date: | 2020-09-04 01:15:57 |
| Message-ID: | 20200904011557.GD19499@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 03, 2020 at 10:50:49AM -0400, Alvaro Herrera wrote:
> I'm not sure you need the second sentence in this comment; keeping the
> "delay initialization until ..." part seems sufficient. If you really
> want to highlight that initialization is costly, maybe just say "delay
> costly initialization".
Thanks for the review.
This extra comment was to answer to Daniel's suggestion upthread, and
the simple wording you are suggesting is much better than what I did,
so I have just added "costly initialization" in those two places.
>> + /*
>> + * Record the Dependency. Note we don't bother to check for duplicate
>> + * dependencies; there's no harm in them.
>> + */
>
> No need to uppercase "dependency". (I know this is carried forward from
> prior comment, but it was equally unnecessary there.)
Thanks, fixed.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2020-09-04 01:21:49 | Re: BUG #16419: wrong parsing BC year in to_date() function |
| Previous Message | Jeff Davis | 2020-09-04 00:53:43 | Re: Disk-based hash aggregate's cost model |