Re: [BUG v13] Crash with event trigger in extension

From: Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: [BUG v13] Crash with event trigger in extension
Date: 2020-09-03 17:41:14
Message-ID: 20200903194114.34af669a@firost
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Wed, 2 Sep 2020 13:53:28 -0400
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:

> On 2020-Sep-02, Jehan-Guillaume de Rorthais wrote:
>
> > Hi,
> >
> > Philippe Beaudoin reported to me a crash he was able to reproduce with some
> > extension update script. Please, find in attachment a script that triggers
> > it. Just edit the three first vars to point to a temporary installation and
> > instance.
> >
> > Some git bisect shows the bug was introduced by b5810de3f4, where
> > multi-statement query strings are using different short memory contexts.
>
> Good find.
>
> I think we should turn your case into a proper TAP test so that we can
> incorporate it, for coverage -- the lines you patch do appear covered,
> but obviously not in these specific conditions. I'm just not very sure
> *where* to add it; maybe src/test/modules/test_extensions is the place
> to have it, though that one doesn't have TAP tests currently. An easy
> addition, though.

Sure, please find in attachment patch v2 adding a regression test.

Regards,

Attachment Content-Type Size
v2-0001-Fix-crash-with-alter-table-event-triggers-in-extensi.patch text/x-patch 5.2 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2020-09-03 17:49:24
Previous Message Alexander Korotkov 2020-09-03 17:32:59 Re: BUG #16606: V 4.25: unable to drop database