Re: Reloptions for table access methods

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Reloptions for table access methods
Date: 2020-09-01 16:20:08
Message-ID: 20200901162008.GA12330@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-Aug-31, Jeff Davis wrote:

> fillRelOptions() validates when filling in a struct to make sure there
> aren't "leftover" options. It does this using a hard-coded parsing
> table that is not extensible.

Hmm, I think that if we're going to do this, we should do it for all
AMs, not just table AMs, since surely index AMs also want extensible
reloptions; and I think that makes the 'validate' mechanism dead code
and so we should remove it.

I think this means that you can have tables with mistyped options, and
you'd not get an error message about them. Is that right? Is that what
we want?

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2020-09-01 16:29:22 Re: Kerberos support broken on MSVC builds for Windows x64?
Previous Message Dave Page 2020-09-01 16:12:17 Re: Kerberos support broken on MSVC builds for Windows x64?