Re: please update ps display for recovery checkpoint

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: "k(dot)jamison(at)fujitsu(dot)com" <k(dot)jamison(at)fujitsu(dot)com>
Cc: 'Justin Pryzby' <pryzby(at)telsasoft(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: please update ps display for recovery checkpoint
Date: 2020-08-31 06:52:44
Message-ID: 20200831065244.GB6555@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 20, 2020 at 05:09:05PM +0900, Michael Paquier wrote:
> That could be helpful. Wouldn't it be better to use "end-of-recovery
> checkpoint" instead? That's the common wording in the code comments.
>
> I don't see the point of patch 0002. In the same paragraph, we
> already know that this applies to any checkpoints.

Thinking more about this.. Could it be better to just add some calls
to set_ps_display() directly in CreateCheckPoint()? This way, both
the checkpointer as well as the startup process at the end of recovery
would benefit from the change.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hao Wu 2020-08-31 07:00:19 Re: ALTER TABLE .. DETACH PARTITION CONCURRENTLY
Previous Message Michael Paquier 2020-08-31 06:23:04 Re: More tests with USING INDEX replident and dropped indexes