Re: Handing off SLRU fsyncs to the checkpointer

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Jakub Wartak <Jakub(dot)Wartak(at)tomtom(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Handing off SLRU fsyncs to the checkpointer
Date: 2020-08-26 18:15:32
Message-ID: 20200826181532.GA17210@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-Aug-25, Jakub Wartak wrote:

> Turning on/off the defer SLRU patch and/or fsync doesn't seem to make
> any difference, so if anyone is curious the next sets of append-only
> bottlenecks is like below:
>
> 14.69% postgres postgres [.] hash_search_with_hash_value
> ---hash_search_with_hash_value
> |--9.80%--BufTableLookup
> | ReadBuffer_common
> | ReadBufferWithoutRelcache
> | XLogReadBufferExtended
> | XLogReadBufferForRedoExtended
> | |--7.76%--btree_xlog_insert
> | | btree_redo
> | | StartupXLOG
> | --1.63%--heap_xlog_insert
> --4.90%--smgropen
> |--2.86%--ReadBufferWithoutRelcache

Looking at an earlier report of this problem I was thinking whether it'd
make sense to replace SMgrRelationHash with a simplehash table; I have a
half-written patch for that, but I haven't completed that work.
However, in the older profile things were looking different, as
hash_search_with_hash_value was taking 35.25%, and smgropen was 33.74%
of it. BufTableLookup was also there but only 1.51%. So I'm not so
sure now that that'll pay off as clearly as I had hoped.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2020-08-26 19:15:51 Re: XMAX_LOCK_ONLY and XMAX_COMMITTED (fk/multixact code)
Previous Message Alvaro Herrera 2020-08-26 18:09:50 Re: Handing off SLRU fsyncs to the checkpointer