Re: More tests with USING INDEX replident and dropped indexes

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Rahila <rahila(dot)syed(at)2ndquadrant(dot)com>
Cc: Euler Taveira <euler(dot)taveira(at)2ndquadrant(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: More tests with USING INDEX replident and dropped indexes
Date: 2020-08-26 12:08:51
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Aug 25, 2020 at 08:59:37PM +0530, Rahila wrote:
> Sorry, I didn't apply correctly. The tests pass for me. In addition, I
> tested with partitioned tables. It works as expected and makes the REPLICA
> IDENTITY 'n' for the partitions as well when an index on a partitioned
> table is dropped.

Indeed. I have added a test for that.

While looking at this patch again, I noticed that the new tests for
contrib/test_decoding/ and the improvements for relreplident are
really two different bullet points, and that the new tests should not
be impacted as long as we switch to NOTHING the replica identity once
its index is dropped. So, for now, I have applied the new decoding
tests with a first commit, and attached is an updated patch which
includes tests in the main regression test suite for
replica_identity.sql, which is more consistent with the rest as that's
the main place where we look at the state of pg_class.relreplident.
I'll go through this part again tomorrow, it is late here.

Attachment Content-Type Size
v3-0001-Reset-pg_class.relreplident-when-associated-repli.patch text/x-diff 8.3 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-08-26 12:18:49 Re: Strange behavior with polygon and NaN
Previous Message Dagfinn Ilmari Mannsåker 2020-08-26 11:47:06 Re: LWLockAcquire and LockBuffer mode argument