| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: some unused parameters cleanup |
| Date: | 2020-08-26 08:11:10 |
| Message-ID: | 20200826081110.GA28952@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 26, 2020 at 06:38:52AM +0200, Peter Eisentraut wrote:
> I had meant to exclude cases like this from this patch set. If you see a
> case like this in *this* patch set, please point it out.
Last time I looked at that a lot of parameters are kept around as a
matter of symmetry with siblings, like tablecmds.c. FWIW:
https://www.postgresql.org/message-id/20190130073317.GP3121@paquier.xyz
Saying that, I can see that you have been careful here and I don't see
anything like that in most of the changes you are proposing here. You
could say that for findNamespace() or _moveBefore() perhaps, but there
are also some routines not making use of an Archive. So this cleanup
looks fine to me.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andy Fan | 2020-08-26 08:21:35 | Re: Improve planner cost estimations for alternative subplans |
| Previous Message | Andy Fan | 2020-08-26 08:03:36 | Re: Hybrid Hash/Nested Loop joins and caching results from subplans |