Re: Implementing Incremental View Maintenance

I have looked into this.

> Hi,
>
> Attached is the rebased patch (v16) to add support for Incremental
> Materialized View Maintenance (IVM). It is able to be applied to
> current latest master branch.
>
> This also includes the following small fixes:
>
> - Add a query check for expressions containing aggregates in it
> - [doc] Add description about which situations IVM is effective or not in
> - Improve hint in log messages
> - Reorganize include directives in codes

- make check passed.
- make check-world passed.

- 0004-Allow-to-prolong-life-span-of-transition-tables-unti.patch:
This one needs a comment to describe what the function does etc.

+void
+SetTransitionTablePreserved(Oid relid, CmdType cmdType)
+{

- 0007-Add-aggregates-support-in-IVM.patch
"Check if the given aggregate function is supporting" shouldn't be
"Check if the given aggregate function is supporting IVM"?

+ * check_aggregate_supports_ivm
+ *
+ * Check if the given aggregate function is supporting

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp