Re: run pgindent on a regular basis / scripted manner

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: run pgindent on a regular basis / scripted manner
Date: 2020-08-17 18:11:47
Message-ID: 20200817181147.rsewwlketeqsjxba@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2020-08-15 13:44:34 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > One thing is that some here are actively against manually adding entries
> > to typedefs.list.
>
> I've been of the opinion that it's pointless to do so under the current
> regime where (a) only a few people do that and (b) we only officially
> re-indent once a year anyway. When I want to manually run pgindent,
> I always pull down a fresh typedefs.list from the buildfarm, which is
> reasonably up-to-date regardless of what people added or didn't add,
> and then add any new typedefs from my current patch to that out-of-tree
> copy.

Well, properly indenting new code still is worthwhile. And once you go
through the trouble of adding the typedefs locally, I don't really see
the reason not to also include them in the commit. Sure it'll not help
much with tree-wide re-indents, but with individual files it can still
make life less painful.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2020-08-17 18:22:15 Re: Corruption during WAL replay
Previous Message Tom Lane 2020-08-17 18:05:24 Re: run pgindent on a regular basis / scripted manner