|From:||Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>|
|To:||Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>|
|Cc:||PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>|
|Subject:||Re: [BUG] Error in BRIN summarization|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On 2020-Aug-11, Alvaro Herrera wrote:
> I think this is more complicated than necessary. It seems easier to
> solve this problem by just checking whether the given root pointer is
> set to InvalidOffsetNumber, which is already done in the existing coding
> of heap_get_root_tuples (only they spell it "0" rather than
> InvalidOffsetNumber, which I propose to change). AFAIR this should only
> happen in the 'anyvisible' mode, so I added that in an assert.
'anyvisible' mode is not required AFAICS; reading the code, I think this
could also hit REINDEX CONCURRENTLY and CREATE INDEX CONCURRENTLY, which
do not use that flag. I didn't try to reproduce it there, though.
Anyway, I'm going to remove that Assert() I added.
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
|Next Message||Dmitry Dolgov||2020-08-12 16:19:02||pg_stat_statements and "IN" conditions|
|Previous Message||Alvaro Herrera||2020-08-12 16:00:06||Re: [BUG] Error in BRIN summarization|