Re: walsender waiting_for_ping spuriously set

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: ashutosh(dot)bapat(at)2ndquadrant(dot)com, Noah Misch <noah(at)leadboat(dot)com>
Subject: Re: walsender waiting_for_ping spuriously set
Date: 2020-08-07 23:18:29
Message-ID: 20200807231829.GA3040@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-Aug-07, Alvaro Herrera wrote:

> I'm thinking in keeping the sentences that were added in that commit,
> maybe like so:
>
> > * We only send regular messages to the client for full decoded
> > * transactions, but a synchronous replication and walsender shutdown
> > * possibly are waiting for a later location. So, before sleeping, we
> > + * send a ping containing the flush location. A reply from standby is
> > + * not needed and would be wasteful most of the time,
> > + * but if the receiver is otherwise idle and walreceiver status messages
> > + * are enabled, this keepalive will trigger a reply. Processing the
> > + * reply will update these MyWalSnd locations.

After rereading this a few more times, I think it's OK as Noah had it,
so I'll just use his wording.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-08-08 01:44:09 Re: Creating a function for exposing memory usage of backend process
Previous Message Alvaro Herrera 2020-08-07 22:55:12 Re: walsender waiting_for_ping spuriously set