Re: LDAP check flapping on crake due to race

From: Noah Misch <noah(at)leadboat(dot)com>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: LDAP check flapping on crake due to race
Date: 2020-08-02 06:10:48
Message-ID: 20200802061048.GA2207@rfd.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Aug 02, 2020 at 05:29:57PM +1200, Thomas Munro wrote:
> There are one or two failures per month on crake. It looks like when
> authentication is rejected, as expected in the tests, the psql process
> is exiting, but there is a race where the Perl script still wants to
> write a dummy query to its stdin (?), so you get:
>
> psql: FATAL: LDAP authentication failed for user "test1"
> ack Broken pipe: write( 13, 'SELECT 1' ) at
> /usr/share/perl5/vendor_perl/IPC/Run/IO.pm line 549.

Do you suppose a fix like e12a472 would cover this? ("psql <&-" fails with
status 1 after successful authentication, and authentication failure gives
status 2.)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2020-08-02 06:11:42 Re: SimpleLruTruncate() mutual exclusion
Previous Message Thomas Munro 2020-08-02 05:29:57 LDAP check flapping on crake due to race