| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Tab completion for VACUUM of partitioned tables |
| Date: | 2020-07-30 01:46:11 |
| Message-ID: | 20200730014611.GB22023@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 30, 2020 at 08:44:26AM +0900, Fujii Masao wrote:
> Isn't it better to add the comment explaining why toast tables are
> excluded from the tab completion for vacuum while they are vacuumable?
Sounds sensible, still it does not apply only to vacuum. I would go
as far as just adding a comment at the beginning of the block for
schema queries:
"Never include toast tables in any of those queries to avoid
unnecessary bloat in the completions."
> The patch looks good to me except that.
Indeed. FWIW, I would also adjust the comment on top of
Query_for_list_of_indexables to not say "index creation", but just
"supporting indexing" instead.
Fujii-san, perhaps you would prefer taking care of this patch? I am
fine to do it if you wish.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-07-30 01:54:34 | Re: IDEA: pg_stat_statements tracking utility statements by tag? |
| Previous Message | Bruce Momjian | 2020-07-30 01:30:50 | Re: PG 13 release notes, first draft |