Re: [PATCH] Tab completion for VACUUM of partitioned tables

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Tab completion for VACUUM of partitioned tables
Date: 2020-07-29 06:21:19
Message-ID: 20200729062119.GF28700@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 29, 2020 at 01:27:07PM +0900, Masahiko Sawada wrote:
> Good catch. The patch looks good to me.

While this patch is logically correct. I think that we should try to
not increase more the number of queries used to scan pg_class
depending on a list of relkinds. For example, did you notice that
your new Query_for_list_of_vacuumables becomes the same query as
Query_for_list_of_indexables? You can make your patch more simple.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hamid Akhtar 2020-07-29 06:56:40 Re: Rethinking opclass member checks and dependency strength
Previous Message Pavel Stehule 2020-07-29 06:18:18 Re: proposal: unescape_text function