| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Steele <david(at)pgmasters(dot)net>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, David Fetter <david(at)fetter(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Oleksandr Shulgin <oleksandr(dot)shulgin(at)zalando(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Oleg Bartunov <obartunov(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] [PATCH] Generic type subscripting |
| Date: | 2020-07-20 16:02:16 |
| Message-ID: | 20200720160216.lav6vmyv6wbg7bfl@localhost |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Sun, Jul 19, 2020 at 02:10:16PM -0500, Justin Pryzby wrote:
>
> I found some minor comment typos.
Thanks!
> I don't think it's enough to claim a beer:
>
> + * container. If you have read until this point, and will submit a meaningful
> + * review of this patch series, I'll owe you a beer at the next PGConfEU.
Well, so far it's the best take I have :)
>
> I'm not sure I understand what this is saying:
>
> + * It's necessary only for field selection, since for
> + * subscripting it's custom code who should define types.
>
> should maybe say: "its custom code should define types."
> (no apostrophe is "possessive")
Yes, you're right. Unfortunately as a non native speaker I'm cursed to
do this kind of stupid typos and wordings. I've incorporated all your
suggestions.
| Attachment | Content-Type | Size |
|---|---|---|
| v32-0001-Base-implementation-of-subscripting-mechanism.patch | text/x-diff | 47.5 KB |
| v32-0002-Subscripting-for-array.patch | text/x-diff | 24.8 KB |
| v32-0003-Subscripting-for-jsonb.patch | text/x-diff | 33.4 KB |
| v32-0004-Subscripting-documentation.patch | text/x-diff | 20.0 KB |
| v32-0005-Polymorphic-subscripting.patch | text/x-diff | 61.6 KB |
| v32-0006-Filling-gaps-in-jsonb-arrays.patch | text/x-diff | 8.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2020-07-20 16:38:00 | Re: Local visibility with logical decoding |
| Previous Message | Tom Lane | 2020-07-20 15:51:19 | Re: Binary support for pgoutput plugin |