| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Steele <david(at)pgmasters(dot)net>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, David Fetter <david(at)fetter(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Oleksandr Shulgin <oleksandr(dot)shulgin(at)zalando(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Oleg Bartunov <obartunov(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] [PATCH] Generic type subscripting |
| Date: | 2020-07-19 19:10:16 |
| Message-ID: | 20200719191016.GW23581@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, May 16, 2020 at 02:28:02PM +0200, Dmitry Dolgov wrote:
> > On Mon, Mar 23, 2020 at 07:30:25AM +0100, Pavel Stehule wrote:
> > ne 22. 3. 2020 v 20:41 odesílatel Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> napsal:
> > > Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> > > > ne 22. 3. 2020 v 18:47 odesílatel Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> napsal:
> > > >> cfbot reports this as failing because of missing include files.
> > > >> Somebody please post a complete patch set?
> > >
> > > > here it is
>
> One more rebase to prepare for 2020-07.
I found some minor comment typos.
I don't think it's enough to claim a beer:
+ * container. If you have read until this point, and will submit a meaningful
+ * review of this patch series, I'll owe you a beer at the next PGConfEU.
I'm not sure I understand what this is saying:
+ * It's necessary only for field selection, since for
+ * subscripting it's custom code who should define types.
should maybe say: "its custom code should define types."
(no apostrophe is "possessive")
--
Justin
| Attachment | Content-Type | Size |
|---|---|---|
| 0007-fix-Polymorphic-subscriptingtxt | text/plain | 1.2 KB |
| 0008-fix-Subscripting-documentationtxt | text/plain | 3.5 KB |
| 0009-fix-Base-implementation-of-subscripting-mechanismtxt | text/plain | 4.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-07-19 20:42:25 | Re: pg_subscription.subslotname is wrongly marked NOT NULL |
| Previous Message | Tom Lane | 2020-07-19 18:03:20 | Fix initdb's unsafe not-null-marking rule |