| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Have SIGHUP instead of SIGTERM for config reload in logical replication launcher |
| Date: | 2020-07-15 15:51:37 |
| Message-ID: | 20200715155137.neksljhll6hbrvdb@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2020-07-15 20:33:59 +0530, Bharath Rupireddy wrote:
> >
> > +1. I will commit this tomorrow unless someone thinks otherwise.
> >
>
> I think versions <= 12, have "pqsignal(SIGHUP,
> logicalrep_launcher_sighup)", not sure why and which commit removed
> logicalrep_launcher_sighup().
commit 1e53fe0e70f610c34f4c9e770d108cd94151342c
Author: Robert Haas <rhaas(at)postgresql(dot)org>
Date: 2019-12-17 13:03:57 -0500
Use PostgresSigHupHandler in more places.
There seems to be no reason for every background process to have
its own flag indicating that a config-file reload is needed.
Instead, let's just use ConfigFilePending for that purpose
everywhere.
Patch by me, reviewed by Andres Freund and Daniel Gustafsson.
Discussion: http://postgr.es/m/CA+TgmoZwDk=BguVDVa+qdA6SBKef=PKbaKDQALTC_9qoz1mJqg@mail.gmail.com
Indeed looks like a typo. Robert, do you concur?
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2020-07-15 16:26:53 | Re: BUG #16419: wrong parsing BC year in to_date() function |
| Previous Message | Andres Freund | 2020-07-15 15:41:18 | Re: recovering from "found xmin ... from before relfrozenxid ..." |