| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | alvherre(at)2ndquadrant(dot)com |
| Cc: | tgl(at)sss(dot)pgh(dot)pa(dot)us, pgbf(at)twiska(dot)com, masao(dot)fujii(at)oss(dot)nttdata(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: min_safe_lsn column in pg_replication_slots view |
| Date: | 2020-07-14 04:38:09 |
| Message-ID: | 20200714.133809.1303714501242829538.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Mon, 13 Jul 2020 13:52:12 -0400, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote in
> On 2020-Jul-13, Alvaro Herrera wrote:
>
> > A much more sensible answer is to initialize the segno to the segment
> > currently being written, as in the attached.
>
> Ran the valgrind test locally and it passes. Pushed it now.
- if (XLogRecPtrIsInvalid(*logSegNo) || segno < *logSegNo)
+ if (segno < *logSegNo)
Oops! Thank you for fixing it!
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-07-14 04:41:43 | Re: Fix header identification |
| Previous Message | Kyotaro Horiguchi | 2020-07-14 04:31:31 | Re: GSSENC'ed connection stalls while reconnection attempts. |