Re: Default setting for enable_hashagg_disk

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Peter Geoghegan <pg(at)bowt(dot)ie>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Default setting for enable_hashagg_disk
Date: 2020-07-13 18:43:16
Message-ID: 20200713184316.GK23581@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers

On Mon, Jul 13, 2020 at 12:47:36PM -0400, Alvaro Herrera wrote:
> On 2020-Jul-13, Jeff Davis wrote:
>
> > On Tue, 2020-07-14 at 02:25 +1200, David Rowley wrote:
> > > Updated summary:
> > > * For hash_mem = Tomas [7], Justin [16]
> > > * For hash_mem_multiplier with a default > 1.0 = DavidG [21]
> > > * For hash_mem_multiplier with default = 1.0 = PeterG [15][0], Tom
> > > [20][24]
> >
> > I am OK with these options, but I still prefer a simple escape hatch.
>
> I'm in favor of hash_mem_multiplier. I think a >1 default is more
> sensible than =1 in the long run, but if strategic vote is what we're
> doing, then I support the =1 option.

I recanted and support hash_mem_multiplier (or something supporting that
behavior, even if it also supports an absolute/scalar value).
https://www.postgresql.org/message-id/20200703145620.GK4107@telsasoft.com

1.0 (or -1) is fine, possibly to be >= 1.0 in master at a later date.

--
Justin

In response to

Browse pgsql-docs by date

  From Date Subject
Next Message Peter Geoghegan 2020-07-13 18:50:10 Re: Default setting for enable_hashagg_disk
Previous Message Tom Lane 2020-07-13 18:38:23 Re: Default setting for enable_hashagg_disk

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabrízio de Royes Mello 2020-07-13 18:46:18 Re: pg_dump bug for extension owned tables
Previous Message Tom Lane 2020-07-13 18:38:23 Re: Default setting for enable_hashagg_disk