| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgbf(at)twiska(dot)com, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, masao(dot)fujii(at)oss(dot)nttdata(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: min_safe_lsn column in pg_replication_slots view |
| Date: | 2020-07-10 23:40:37 |
| Message-ID: | 20200710234037.GA24580@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-Jul-09, Alvaro Herrera wrote:
> I think we should define InvalidXLogSegNo to be ~((uint64)0) and add a
> macro to test for that.
That's overkill really. I just used zero. Running
contrib/test_decoding under valgrind, this now passes.
I think I'd rather do away with the compare to zero, and initialize to
something else in GetWALAvailability, though. What we're doing seems
unclean and unclear.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-fix-uninitialized-value.patch | text/x-diff | 1.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2020-07-11 00:16:33 | Re: Default setting for enable_hashagg_disk |
| Previous Message | Peter Geoghegan | 2020-07-10 23:10:53 | Re: Default setting for enable_hashagg_disk |