Re: Warn when parallel restoring a custom dump without data offsets

From: David Gilman <dgilman(at)gilslotd(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, pryzby(at)telsasoft(dot)com
Subject: Re: Warn when parallel restoring a custom dump without data offsets
Date: 2020-07-08 03:19:35
Message-ID: 20200708031935.56el54wraqmd3fci@dar.local
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Thu, Jul 02, 2020 at 05:25:21PM -0400, Tom Lane wrote:
> I guess I'm completely confused about the purpose of these patches.
> Far from coping with the situation of an unseekable file, they appear
> to change pg_restore so that it fails altogether if it can't seek
> its input file. Why would we want to do this?

I'm not sure where the "fails altogether if it can't seek" is. The
"Skip tables in pg_restore" patch retains the old fread() logic. The
--disable-seeking stuff was just to support tests, and thanks to
help from Justin Pryzby the tests no longer require it. I've attached
the updated patch set.

Note that this still shouldn't be merged because of Justin's bug report
in 20200706050129(dot)GW4107(at)telsasoft(dot)com which is unrelated to this change
but will leave you with flaky CI until it's fixed.

David Gilman :DG<

Attachment Content-Type Size
0001-Scan-all-TOCs-when-restoring-a-custom-dump-file-with.patch text/x-diff 3.6 KB
0002-Add-integration-test-for-out-of-order-TOC-requests-i.patch text/x-diff 6.1 KB
0003-Remove-unused-seek-check-in-tar-dump-format.patch text/x-diff 1.1 KB
0004-Skip-tables-in-pg_restore-by-seeking-instead-of-read.patch text/x-diff 1.5 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2020-07-08 03:26:31 Re: Default setting for enable_hashagg_disk (hash_mem)
Previous Message torikoshia 2020-07-08 02:55:56 Re: Modifying data type of slot_keep_segs from XLogRecPtr to XLogSegNo