Re: pg_read_file() with virtual files returns empty string

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: pg_read_file() with virtual files returns empty string
Date: 2020-07-04 16:39:10
Message-ID: 20200704163910.GO4107@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Joe

Thanks for addressing this.

But I noticed that cfbot is now populating with failures like:

https://travis-ci.org/github/postgresql-cfbot/postgresql/builds/704898559
genfile.c: In function ‘read_binary_file’:
genfile.c:192:5: error: ignoring return value of ‘fread’, declared with attribute warn_unused_result [-Werror=unused-result]
fread(rbuf, 1, 1, file);
^
cc1: all warnings being treated as errors
<builtin>: recipe for target 'genfile.o' failed

--
Justin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-07-04 16:52:24 Re: pg_read_file() with virtual files returns empty string
Previous Message movead.li@highgo.ca 2020-07-04 14:56:17 Re: POC and rebased patch for CSN based snapshots