Re: Remove Deprecated Exclusive Backup Mode

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove Deprecated Exclusive Backup Mode
Date: 2020-07-02 13:52:43
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


* Magnus Hagander (magnus(at)hagander(dot)net) wrote:
> On Thu, Jul 2, 2020 at 1:06 AM Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com>
> wrote:
> > function to list in progress non-exclusive backup and related backend pid
> > might
> > be a good start?
> I think it would make perfect sense to show manual (exclusive or
> non-exclusive) base backups in pg_stat_progress_basebackup. There's no
> fundamental need that one should only be for base backups taken with
> pg_basebackup. In fact, I'd argue that's a mistake in the view in v13 that
> it does not include this information.

I agree entirely that it was a mistake in v13 to not include this- and
to not include a way for other backup tools to report their progress.
This is a good example of why we really need an in-core non-streamed
backup capability, imv, because if we don't we end up with things like
this that are just thinking about streaming basebackups. We also have
no in-core code that is user-facing that exercises the low-level backup

> It could have "phase" set to "manual non-exclusive" for example, and leave
> the other fields at NULL.


> I guess in theory even for exclusive ones, with the pid column set to NULL.
> (As Stephen mentioned at some point in the future we might also want to
> extend it to allow these tools to report their progress as well into it,
> probably by just calling an admin function on the connection that they
> already have).

Right, that wouldn't have been hard to include and would have been quite



In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-07-02 14:01:27 Re: POC: rational number type (fractions)
Previous Message Stephen Frost 2020-07-02 13:46:11 Re: Remove Deprecated Exclusive Backup Mode