Re: Rotten parts of src/backend/replication/README

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Rotten parts of src/backend/replication/README
Date: 2020-07-02 05:03:06
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Jun 30, 2020 at 10:11:04AM +0200, Peter Eisentraut wrote:
> On 2020-05-04 07:50, Michael Paquier wrote:
>> Yeah. The years have visibly proved that the README had updates when
>> it came to the general descriptions of the libpqwalreceiver interface,
>> but that we had better consolidate the header to give some
>> documentation to whoever plays with this interface. Attached is a
>> patch to address all that, where I simplified the README and added
>> some description to all the callbacks. Thoughts are welcome. I'll
>> add that to the next CF. Now I don't see any actual problems in
>> getting that on HEAD before v13 forks. But let's gather more opinions
>> first.
> This patch looks good to me.

Thanks for the review, Peter. After an extra read, the description
of walrcv_create_slot_fn was not complete (missed the end of the
sentence to say that NULL is returned for a physical slot) and had a
grammar mistake. So I have fixed this part, and applied the patch on
HEAD. Perhaps things could be improved further more, so if anybody
has any suggestion please feel free.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-07-02 05:35:16 Re: Cache lookup errors with functions manipulation object addresses
Previous Message Kyotaro Horiguchi 2020-07-02 04:53:30 Re: Remove page-read callback from XLogReaderState.