| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | masao(dot)fujii(at)oss(dot)nttdata(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Review for GetWALAvailability() |
| Date: | 2020-06-27 00:46:10 |
| Message-ID: | 20200627004610.GA7754@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-Jun-25, Kyotaro Horiguchi wrote:
> It is error-prone restriction, as discussed before.
>
> Without changing updator-side, invalid restart_lsn AND valid
> invalidated_at can be regarded as the lost state. With the following
> change suggested by Fujii-san we can avoid the confusing status.
>
> With attached first patch on top of the slot-dirtify fix below, we get
> "lost" for invalidated slots after restart.
Makes sense. I pushed this change, thanks.
> The confusing status can be avoided without fixing it, but I prefer to
> fix it. As Fujii-san suggested upthread, couldn't we remember
> lastRemovedSegNo in the contorl file? (Yeah, it cuases a bump of
> PG_CONTROL_VERSION and CATALOG_VERSION_NO?).
I think that's a pg14 change. Feel free to submit a patch to the
commitfest.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2020-06-27 01:22:56 | Added tab completion for the missing options in copy statement |
| Previous Message | Peter Geoghegan | 2020-06-27 00:24:36 | Re: Default setting for enable_hashagg_disk |