From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jeff Davis <pgsql(at)j-davis(dot)com> |
Subject: | Re: Missing HashAgg EXPLAIN ANALYZE details for parallel plans |
Date: | 2020-06-19 19:14:45 |
Message-ID: | 20200619191445.GA20665@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2020-Jun-19, David Rowley wrote:
> > + size = offsetof(SharedAggInfo, sinstrument)
> > + + pcxt->nworkers * sizeof(AggregateInstrumentation);
> >
> > => There's a couple places where I'd prefer to see "+" at the end of the
> > preceding line (but YMMV).
>
> I pretty much just copied the whole of that code from nodeSort.c. I'm
> more inclined to just keep it as similar to that as possible. However,
> if pgindent decides otherwise, then I'll go with that. I imagine it
> won't move it though as that code has already been through indentation
> a few times before.
pgindent won't change your choice here. This seems an ideological
issue; each committer has got their style. Some people prefer to put
operators at the end of the line, others do it this way.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2020-06-19 19:17:53 | Re: Fast DSM segments |
Previous Message | Fujii Masao | 2020-06-19 18:57:16 | Re: [PATCH] Allow to specify restart_lsn in pg_create_physical_replication_slot() |