| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "masao(dot)fujii(at)gmail(dot)com" <masao(dot)fujii(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "euler(at)timbira(dot)com(dot)br" <euler(at)timbira(dot)com(dot)br> |
| Subject: | Re: Add support for INDEX_CLEANUP and TRUNCATE to vacuumdb |
| Date: | 2020-06-11 07:09:41 |
| Message-ID: | 20200611070941.GC365021@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 11, 2020 at 12:41:17AM +0000, Bossart, Nathan wrote:
> I quickly put together a patch to add INDEX_CLEANUP and TRUNCATE to
> vacuumdb before noticing a previous thread for it [0]. My take on it
> was to just name the options --skip-index-cleanup and --skip-truncate.
> While that does not give you a direct mapping to the corresponding
> VACUUM options, it simplifies the patch by avoiding the boolean
> parameter parsing stuff altogether.
Cannot blame you for that. There is little sense to have a pure
mapping with the options here with some custom boolean parsing. What
about naming them --no-index-cleanup and --no-truncate instead? I
would suggest to track the option values with variables named like
do_truncate and do_index_cleanup. That would be similar with what we
do with --no-sync for example.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-06-11 07:13:45 | Re: Add tap test for --extra-float-digits option |
| Previous Message | Fabien COELHO | 2020-06-11 07:07:40 | Re: Internal key management system |