| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Hiroshi Saito <hiroshi(at)winpg(dot)jp>, "Inoue, Hiroshi" <h-inoue(at)dream(dot)email(dot)ne(dot)jp> |
| Subject: | Re: Removal of currtid()/currtid2() and some table AM cleanup |
| Date: | 2020-06-05 06:07:34 |
| Message-ID: | 20200605060734.GV89559@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 04, 2020 at 10:59:05AM -0700, Andres Freund wrote:
> What's the point of that change? I think the differentiation between
> heapam_handler.c and heapam.c could be clearer, but if anything, I'd
> argue that heap_get_latest_tid is sufficiently low-level that it'd
> belong in heapam.c.
Well, heap_get_latest_tid() is only called in heapam_handler.c if
anything, as it is not used elsewhere and not publish it. And IMO we
should try to encourage using table_get_latest_tid() instead if some
plugins need that. Anyway, if you are opposed to this change, I won't
push hard for it either.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-06-05 06:07:39 | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |
| Previous Message | Thomas Munro | 2020-06-05 06:03:59 | Re: BufFileRead() error signalling |