| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, masao(dot)fujii(at)oss(dot)nttdata(dot)com, amit(dot)kapila16(at)gmail(dot)com, pasim(at)vmware(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: elog(DEBUG2 in SpinLocked section. |
| Date: | 2020-06-04 01:43:56 |
| Message-ID: | 20200604014356.GM89559@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 03, 2020 at 12:36:34AM -0400, Tom Lane wrote:
> Should we think about adding automated detection of this type of
> mistake? I don't like the attached as-is because of the #include
> footprint expansion, but maybe we can find a better way.
I think that this one first boils down to the FRONTEND dependency in
those headers. Or in short, spin.h may get loaded by the frontend but
we have a backend-only API, no?
> It's actually worse in the back branches, because elog() did not have
> a good short-circuit path like ereport() does. +1 for back-patch.
Thanks, got that fixed down to 9.5.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2020-06-04 01:53:59 | Re: libpq copy error handling busted |
| Previous Message | Tom Lane | 2020-06-04 01:35:53 | Re: libpq copy error handling busted |