Re: Asynchronous Append on postgres_fdw nodes.

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: a(dot)lepikhov(at)postgrespro(dot)ru
Cc: etsuro(dot)fujita(at)gmail(dot)com, movead(dot)li(at)highgo(dot)ca, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Asynchronous Append on postgres_fdw nodes.
Date: 2020-06-04 06:00:15
Message-ID: 20200604.150015.2305436578805492574.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello, Andrey.

At Wed, 3 Jun 2020 15:00:06 +0500, Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru> wrote in
> This patch no longer applies cleanly.
> In addition, code comments contain spelling errors.

Sure. Thaks for noticing of them and sorry for the many typos.
Additional item in WaitEventIPC conflicted with this.

I found the following typos.

connection.c:
s/Rerturns/Returns/
postgres-fdw.c:
s/Retrive/Retrieve/
s/ForeginScanState/ForeignScanState/
s/manipuration/manipulation/
s/asyncstate/async state/
s/alrady/already/

nodeAppend.c:
s/Rery/Retry/

createplan.c:
s/chidlren/children/

resowner.c:
s/identier/identifier/ X 2

execnodes.h:
s/sutff/stuff/

plannodes.h:
s/asyncronous/asynchronous/


Removed a useless variable PgFdwScanState.result_ready.
Removed duplicate code from remove_async_node() by using move_to_next_waiter().
Done some minor cleanups.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
v3-0001-Allow-wait-event-set-to-be-registered-to-resource.patch text/x-patch 9.3 KB
v3-0002-infrastructure-for-asynchronous-execution.patch text/x-patch 46.9 KB
v3-0003-async-postgres_fdw.patch text/x-patch 55.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Laurenz Albe 2020-06-04 06:07:24 Re: what can go in root.crt ?
Previous Message Michael Paquier 2020-06-04 05:19:01 Re: Expand the use of check_canonical_path() for more GUCs